linux-kernel - Re: [V2][PATCH] dmaengine: xilinx: dpdma: initialize registers before request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJla/qT1UO1gb/OD@vkoul-mobl.Dlink>
Date:   Mon, 10 May 2021 21:40:38 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     quanyang.wang@...driver.com
Cc:     Hyun Kwon <hyun.kwon@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Michal Simek <michal.simek@...inx.com>,
        Tejas Upadhyay <tejasu@...inx.com>, dmaengine@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [V2][PATCH] dmaengine: xilinx: dpdma: initialize registers
 before request_irq

On 30-04-21, 14:40, quanyang.wang@...driver.com wrote:
> From: Quanyang Wang <quanyang.wang@...driver.com>
> 
> In some scenarios (kdump), dpdma hardware irqs has been enabled when
> calling request_irq in probe function, and then the dpdma irq handler
> xilinx_dpdma_irq_handler is invoked to access xdev->chan[i]. But at
> this moment xdev->chan[i] hasn't been initialized.
> 
> We should ensure the dpdma controller to be in a consistent and
> clean state before further initialization. So add dpdma_hw_init()
> to do this.
> 
> Furthermore, in xilinx_dpdma_disable_irq, disable all interrupts
> instead of error interrupts.

Applied, thanks

-- 
~Vinod