linux-kernel - Re: [RFC PATCH v2 3/3] sched/doc: Update the CPU capacity asymmetry bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210510163329.GA8567@e120325.cambridge.arm.com>
Date:   Mon, 10 May 2021 17:33:29 +0100
From:   Beata Michalska <beata.michalska@....com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        mingo@...hat.com, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, valentin.schneider@....com,
        dietmar.eggemann@....com, corbet@....net, linux-doc@...r.kernel.org
Subject: Re: [RFC PATCH v2 3/3] sched/doc: Update the CPU capacity asymmetry
 bits

On Wed, Apr 28, 2021 at 10:19:10AM -0700, Randy Dunlap wrote:
> On 4/28/21 2:32 AM, Beata Michalska wrote:
> > Update the documentation bits referring to capacity aware scheduling
> > with regards to newly introduced SD_ASYM_CPUCAPACITY_FULL shed_domain
> 
>                                                             sched_domain
> I guess.
> 
> > flag.
> > 
> > Signed-off-by: Beata Michalska <beata.michalska@....com>
> > ---
> >  Documentation/scheduler/sched-capacity.rst | 6 ++++--
> >  Documentation/scheduler/sched-energy.rst   | 2 +-
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/scheduler/sched-capacity.rst b/Documentation/scheduler/sched-capacity.rst
> > index 9b7cbe4..92d16e7 100644
> > --- a/Documentation/scheduler/sched-capacity.rst
> > +++ b/Documentation/scheduler/sched-capacity.rst
> > @@ -284,8 +284,10 @@ whether the system exhibits asymmetric CPU capacities. Should that be the
> >  case:
> >  
> >  - The sched_asym_cpucapacity static key will be enabled.
> > -- The SD_ASYM_CPUCAPACITY flag will be set at the lowest sched_domain level that
> > -  spans all unique CPU capacity values.
> > +- The SD_ASYM_CPUCAPACITY_FULL flag will be set at the lowest sched_domain
> > +  level that spans all unique CPU capacity values.
> > +- The SD_ASYM_CPUCAPACITY flag will be set for any sched_domain that spans
> > +  cpus with any range of asymmetry.
> 
>      CPUs
> please.
> 
> >  
> >  The sched_asym_cpucapacity static key is intended to guard sections of code that
> >  cater to asymmetric CPU capacity systems. Do note however that said key is
> > diff --git a/Documentation/scheduler/sched-energy.rst b/Documentation/scheduler/sched-energy.rst
> > index afe02d3..8fbce5e 100644
> > --- a/Documentation/scheduler/sched-energy.rst
> > +++ b/Documentation/scheduler/sched-energy.rst
> > @@ -328,7 +328,7 @@ section lists these dependencies and provides hints as to how they can be met.
> >  
> >  As mentioned in the introduction, EAS is only supported on platforms with
> >  asymmetric CPU topologies for now. This requirement is checked at run-time by
> > -looking for the presence of the SD_ASYM_CPUCAPACITY flag when the scheduling
> > +looking for the presence of the SD_ASYM_CPUCAPACITY_FULL flag when the scheduling
> >  domains are built.
> >  
> >  See Documentation/scheduler/sched-capacity.rst for requirements to be met for this
> > 
>

Thank you for having a look!
Fixes applied to v3.

---
BR
B.

> thanks.
> -- 
> ~Randy
>