linux-kernel - Re: [PATCH rdma-rc] RDMA/siw: Properly check send and receive CQ pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <OF52748745.A17A3172-ON002586D1.0060334D-002586D1.00603353@notes.na.collabserv.com>
Date:   Mon, 10 May 2021 17:30:45 +0000
From:   "Bernard Metzler" <BMT@...ich.ibm.com>
To:     "Leon Romanovsky" <leon@...nel.org>
Cc:     "Doug Ledford" <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...dia.com>,
        "Leon Romanovsky" <leonro@...dia.com>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "linux-rdma" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH rdma-rc] RDMA/siw: Properly check send and receive CQ pointers

-----"Leon Romanovsky" <leon@...nel.org> wrote: -----

>To: "Doug Ledford" <dledford@...hat.com>, "Jason Gunthorpe"
><jgg@...dia.com>
>From: "Leon Romanovsky" <leon@...nel.org>
>Date: 05/09/2021 01:39PM
>Cc: "Leon Romanovsky" <leonro@...dia.com>, "Bernard Metzler"
><bmt@...ich.ibm.com>, linux-kernel@...r.kernel.org,
>linux-rdma@...r.kernel.org
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Properly check send and
>receive CQ pointers
>
>From: Leon Romanovsky <leonro@...dia.com>
>
>The check for the NULL of pointer received from container_of is
>incorrect by definition as it points to some random memory.
>
>Change such check with proper NULL check of SIW QP attributes.
>
>Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
>Signed-off-by: Leon Romanovsky <leonro@...dia.com>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index d2313efb26db..917c8a919f38 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -300,7 +300,6 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> 	struct siw_ucontext *uctx =
> 		rdma_udata_to_drv_context(udata, struct siw_ucontext,
> 					  base_ucontext);
>-	struct siw_cq *scq = NULL, *rcq = NULL;
> 	unsigned long flags;
> 	int num_sqe, num_rqe, rv = 0;
> 	size_t length;
>@@ -343,10 +342,8 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> 		rv = -EINVAL;
> 		goto err_out;
> 	}
>-	scq = to_siw_cq(attrs->send_cq);
>-	rcq = to_siw_cq(attrs->recv_cq);
> 
>-	if (!scq || (!rcq && !attrs->srq)) {
>+	if (!attrs->send_cq || (!attrs->recv_cq && !attrs->srq)) {
> 		siw_dbg(base_dev, "send CQ or receive CQ invalid\n");
> 		rv = -EINVAL;
> 		goto err_out;
>@@ -401,8 +398,8 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> 		}
> 	}
> 	qp->pd = pd;
>-	qp->scq = scq;
>-	qp->rcq = rcq;
>+	qp->scq = to_siw_cq(attrs->send_cq);
>+	qp->rcq = to_siw_cq(attrs->recv_cq);
> 
> 	if (attrs->srq) {
> 		/*
>-- 
>2.31.1
>
>

Many thanks Leon!

Reviewed-by: Bernard Metzler <bmt@...ich.ibm.com>