linux-kernel - Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YJlw5fk0ORhioDb4@epycbox.lan>
Date:   Mon, 10 May 2021 10:44:05 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     Nava kishore Manne <navam@...inx.com>
Cc:     Moritz Fischer <mdf@...nel.org>,
        "trix@...hat.com" <trix@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Michal Simek <michals@...inx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>,
        "chinnikishore369@...il.com" <chinnikishore369@...il.com>
Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support

On Wed, Mar 03, 2021 at 10:11:51AM +0000, Nava kishore Manne wrote:
> Ping!
> 
> > -----Original Message-----
> > From: Nava kishore Manne
> > Sent: Wednesday, January 27, 2021 2:43 PM
> > To: Moritz Fischer <mdf@...nel.org>
> > Cc: trix@...hat.com; robh+dt@...nel.org; Michal Simek
> > <michals@...inx.com>; linux-fpga@...r.kernel.org;
> > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> > kernel@...r.kernel.org; git <git@...inx.com>; chinnikishore369@...il.com
> > Subject: RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support
> > 
> > Hi Moritz,
> > 
> > 	Thanks for the review.
> > Please find my response inline.
> > 
> > > -----Original Message-----
> > > From: Moritz Fischer <mdf@...nel.org>
> > > Sent: Friday, January 22, 2021 10:47 AM
> > > To: Nava kishore Manne <navam@...inx.com>
> > > Cc: mdf@...nel.org; trix@...hat.com; robh+dt@...nel.org; Michal Simek
> > > <michals@...inx.com>; linux-fpga@...r.kernel.org;
> > > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > > linux- kernel@...r.kernel.org; git <git@...inx.com>;
> > > chinnikishore369@...il.com
> > > Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading
> > > support
> > >
> > > On Mon, Jan 18, 2021 at 08:20:57AM +0530, Nava kishore Manne wrote:
> > > > This commit adds secure flags to the framework to support secure
> > > > BitStream Loading.
> > > >
> > > > Signed-off-by: Nava kishore Manne <nava.manne@...inx.com>
> > > > ---
> > > >  drivers/fpga/of-fpga-region.c | 10 ++++++++++
> > > > include/linux/fpga/fpga-mgr.h | 12 ++++++++++++
> > > >  2 files changed, 22 insertions(+)
> > > >
> > > > diff --git a/drivers/fpga/of-fpga-region.c
> > > > b/drivers/fpga/of-fpga-region.c index e405309baadc..3a5eb4808888
> > > > 100644
> > > > --- a/drivers/fpga/of-fpga-region.c
> > > > +++ b/drivers/fpga/of-fpga-region.c
> > > > @@ -228,6 +228,16 @@ static struct fpga_image_info
> > > *of_fpga_region_parse_ov(
> > > >  	if (of_property_read_bool(overlay, "encrypted-fpga-config"))
> > > >  		info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM;
> > > >
> > > > +	if (of_property_read_bool(overlay, "userkey-encrypted-fpga-
> > > config"))
> > > > +		info->flags |=
> > > FPGA_MGR_USERKEY_ENCRYPTED_BITSTREAM;
> > >
> > > Can this just be encrypted-fpga-config/FPGA_MGR_ENCRYPTED?
> > 
> > In Encryption we have two kinds of use case one is Encrypted Bitstream
> > loading with Device-key and Other one is Encrypted Bitstream loading with
> > User-key. To differentiate both the use cases this Changes are needed.
> > 
> > Regards,
> > Navakishore.

Is this region specific, or could this be a sysfs attribute?

- Moritz