linux-kernel - Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b280c0fc105ededc399ee22b940e671@walle.cc>
Date:   Mon, 10 May 2021 22:23:18 +0200
From:   Michael Walle <michael@...le.cc>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Vladimir Zapolskiy <vz@...ia.com>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <p.yadav@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK

Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi 
> *spifi,
>  		ctrl |= SPIFI_CTRL_DUAL;
>  	}
> 
> -	switch (mode & (SPI_CPHA | SPI_CPOL)) {
> +	switch (mode & SPI_MODE_X_MASK) {
>  	case SPI_MODE_0:
>  		ctrl &= ~SPIFI_CTRL_MODE3;
>  		break;

Reviewed-by: Michael Walle <michael@...le.cc>

-michael