linux-kernel - Re: [PATCH v2 2/3] PCI: dwc: Visconti: PCIe RC controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 May 2021 15:49:28 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-pci@...r.kernel.org, punit1.agrawal@...hiba.co.jp,
        yuji2.ishikawa@...hiba.co.jp, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] PCI: dwc: Visconti: PCIe RC controller driver

On Mon, May 10, 2021 at 04:47:36PM +0900, Nobuhiro Iwamatsu wrote:
> On Thu, Apr 29, 2021 at 06:10:40PM -0500, Bjorn Helgaas wrote:

> > > +#define  PCIE_UL_EDMA_INT3		BIT(5)
> > > +#define  PCIE_UL_S_INT_EVENT_MASK1_ALL  (PCIE_UL_CFG_PME_INT | PCIE_UL_CFG_LINK_EQ_REQ_INT | \
> > > +					 PCIE_UL_EDMA_INT0 | PCIE_UL_EDMA_INT1 | \
> > > +					 PCIE_UL_EDMA_INT2 | PCIE_UL_EDMA_INT3)
> > > +
> > 
> > Please wrap the code here and below so it fits nicely in 80 columns.
> 
> checkpatch.pl allows up to 100 characters, is this a PCI driver rule?

The general rule is "match what's around you."  So I guess that makes
it a drivers/pci/ rule.

> > > +	pp->irq = platform_get_irq_byname(pdev, "intr");
> > > +	if (pp->irq < 0) {
> > > +		dev_err(dev, "interrupt intr is missing");
> > 
> > Make your error messages consistently capitalized (or consistently not
> > capitalized).
> 
> Sorry, I didn't understand this point correctly.
> Does this mean capitalize the first letter of the message?

Some of your messages are capitalized and others are not:

  dev_info(pci->dev, "Link failure\n"
  dev_err(dev, "Failed to get refclk clock: %ld\n"
  dev_err(dev, "Failed to get sysclk clock: %ld\n"
  dev_err(dev, "Failed to get auxclk clock: %ld\n"
  dev_err(dev, "interrupt intr is missing"
  dev_dbg(dev, "Applied default link speed\n"
  dev_dbg(dev, "link speed Gen %d"
  dev_err(dev, "Failed to initialize host\n"

I don't really care whether they're all capitalized or none are
capitalized, but they should all be the same.  Otherwise it just looks
sloppy.

Bjorn