linux-kernel - Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <OFCA0BD73F.A7CD6605-ON002586D1.002E4672-002586D1.002E467F@notes.na.collabserv.com>
Date:   Mon, 10 May 2021 08:25:27 +0000
From:   "Bernard Metzler" <BMT@...ich.ibm.com>
To:     "Leon Romanovsky" <leon@...nel.org>
Cc:     "Doug Ledford" <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...dia.com>,
        "Leon Romanovsky" <leonro@...dia.com>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "linux-rdma" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry

-----"Leon Romanovsky" <leon@...nel.org> wrote: -----

>To: "Doug Ledford" <dledford@...hat.com>, "Jason Gunthorpe"
><jgg@...dia.com>
>From: "Leon Romanovsky" <leon@...nel.org>
>Date: 05/09/2021 01:41PM
>Cc: "Leon Romanovsky" <leonro@...dia.com>, "Bernard Metzler"
><bmt@...ich.ibm.com>, linux-kernel@...r.kernel.org,
>linux-rdma@...r.kernel.org
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Release xarray entry
>
>From: Leon Romanovsky <leonro@...dia.com>
>
>The xarray entry is allocated in siw_qp_add(), but release was
>missed in case zero-sized SQ was discovered.
>
>Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and
>Receive Queues.")
>Signed-off-by: Leon Romanovsky <leonro@...dia.com>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index 917c8a919f38..3f175f220a22 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -375,7 +375,7 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> 	else {
> 		/* Zero sized SQ is not supported */
> 		rv = -EINVAL;
>-		goto err_out;
>+		goto err_out_xa;
> 	}
> 	if (num_rqe)
> 		num_rqe = roundup_pow_of_two(num_rqe);
>-- 
>2.31.1
>
>
Thanks Leon!

Reviewed-by: Bernard Metzler <bmt@...ich.ibm.com>