linux-kernel - Re: [PATCH] drm/amd/display: remove unused function dc_link_perform_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97fc07d6-dcfa-8d04-7658-311df58745e5@amd.com>
Date:   Mon, 10 May 2021 19:49:16 -0400
From:   Aurabindo Pillai <aurabindo.pillai@....com>
To:     Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Rouven Czerwinski <rouven@...rwinskis.de>
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rouven Czerwinski <r.czerwinski@...gutronix.de>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, kernel@...gutronix.de
Subject: Re: [PATCH] drm/amd/display: remove unused function
 dc_link_perform_link_training



On 2021-05-10 5:33 p.m., Rodrigo Siqueira wrote:
> LGTM,
> 
> Jay, any comment?

None, LGTM, and this applied already.
> 
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>
> 
> On 05/08, Rouven Czerwinski wrote:
>> This function is not used anywhere, remove it. It was added in
>> 40dd6bd376a4 ("drm/amd/display: Linux Set/Read link rate and lane count
>> through debugfs") and moved in fe798de53a7a ("drm/amd/display: Move link
>> functions from dc to dc_link"), but a user is missing.
>>
>> Signed-off-by: Rouven Czerwinski <r.czerwinski@...gutronix.de>
>> ---
>>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 13 -------------
>>   drivers/gpu/drm/amd/display/dc/dc_link.h      |  3 ---
>>   2 files changed, 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> index 3fb0cebd6938..55c5cf2264b3 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>> @@ -3553,19 +3553,6 @@ void dc_link_set_drive_settings(struct dc *dc,
>>   	dc_link_dp_set_drive_settings(dc->links[i], lt_settings);
>>   }
>>   
>> -void dc_link_perform_link_training(struct dc *dc,
>> -				   struct dc_link_settings *link_setting,
>> -				   bool skip_video_pattern)
>> -{
>> -	int i;
>> -
>> -	for (i = 0; i < dc->link_count; i++)
>> -		dc_link_dp_perform_link_training(
>> -			dc->links[i],
>> -			link_setting,
>> -			skip_video_pattern);
>> -}
>> -
>>   void dc_link_set_preferred_link_settings(struct dc *dc,
>>   					 struct dc_link_settings *link_setting,
>>   					 struct dc_link *link)
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc_link.h b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> index fc5622ffec3d..45c927cd27ab 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc_link.h
>> +++ b/drivers/gpu/drm/amd/display/dc/dc_link.h
>> @@ -363,9 +363,6 @@ bool dc_link_is_hdcp22(struct dc_link *link, enum signal_type signal);
>>   void dc_link_set_drive_settings(struct dc *dc,
>>   				struct link_training_settings *lt_settings,
>>   				const struct dc_link *link);
>> -void dc_link_perform_link_training(struct dc *dc,
>> -				   struct dc_link_settings *link_setting,
>> -				   bool skip_video_pattern);
>>   void dc_link_set_preferred_link_settings(struct dc *dc,
>>   					 struct dc_link_settings *link_setting,
>>   					 struct dc_link *link);
>> -- 
>> 2.31.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@...ts.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C9724972184d64ad6e7e008d913010665%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637561717696066502%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=vUFEeBJwjTDnI9l8MGDiW8%2FoX7LINZi%2FfD4A004QfLs%3D&amp;reserved=0
> 

-- 
Regards,
Aurabindo Pillai