linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8350: fix the node unit addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG3jFyukM7tYMdQC_0HWGUBLZtafYu21yvk2LDLS0Ha_jJKm8g@mail.gmail.com>
Date:   Mon, 10 May 2021 10:31:40 +0200
From:   Robert Foss <robert.foss@...aro.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8350: fix the node unit addresses

Hey Vinod,

Thanks for catching this.

On Mon, 10 May 2021 at 09:05, Vinod Koul <vkoul@...nel.org> wrote:
>
> Some node unit addresses were put wrongly in the dts, resulting in
> below warning when run with W=1
>
> arch/arm64/boot/dts/qcom/sm8350.dtsi:693.34-702.5: Warning (simple_bus_reg): /soc@...hermal-sensor@...2000: simple-bus unit address format error, expected "c263000"
> arch/arm64/boot/dts/qcom/sm8350.dtsi:704.34-713.5: Warning (simple_bus_reg): /soc@...hermal-sensor@...3000: simple-bus unit address format error, expected "c265000"
> arch/arm64/boot/dts/qcom/sm8350.dtsi:1180.32-1185.5: Warning (simple_bus_reg): /soc@...nterconnect@...0000: simple-bus unit address format error, expected "90c0000"
>
> Fix by correcting to the correct address as given in reg node
>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8350.dtsi | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index a8cd224a2f31..d015a9ca95a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -6,6 +6,7 @@
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/clock/qcom,gcc-sm8350.h>
>  #include <dt-bindings/clock/qcom,rpmh.h>
> +#include <dt-bindings/interconnect/qcom,sm8350.h>
>  #include <dt-bindings/mailbox/qcom-ipcc.h>
>  #include <dt-bindings/power/qcom-aoss-qmp.h>
>  #include <dt-bindings/power/qcom-rpmpd.h>
> @@ -689,7 +690,7 @@ pdc: interrupt-controller@...0000 {
>                         interrupt-controller;
>                 };
>
> -               tsens0: thermal-sensor@...2000 {
> +               tsens0: thermal-sensor@...3000 {
>                         compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
>                         reg = <0 0x0c263000 0 0x1ff>, /* TM */
>                               <0 0x0c222000 0 0x8>; /* SROT */
> @@ -700,7 +701,7 @@ tsens0: thermal-sensor@...2000 {
>                         #thermal-sensor-cells = <1>;
>                 };
>
> -               tsens1: thermal-sensor@...3000 {
> +               tsens1: thermal-sensor@...5000 {
>                         compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
>                         reg = <0 0x0c265000 0 0x1ff>, /* TM */
>                               <0 0x0c223000 0 0x8>; /* SROT */
> @@ -1176,7 +1177,7 @@ usb_2_ssphy: phy@...be00 {
>                         };
>                 };
>
> -               dc_noc: interconnect@...0000 {
> +               dc_noc: interconnect@...0000 {
>                         compatible = "qcom,sm8350-dc-noc";
>                         reg = <0 0x090c0000 0 0x4200>;
>                         #interconnect-cells = <1>;

Reviewed-by: Robert Foss <robert.foss@...aro.org>