linux-kernel - Re: [PATCH] EDAC/thunderx: Fix an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 May 2021 10:36:37 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     rric@...nel.org, mchehab@...nel.org, tony.luck@...el.com,
        james.morse@....com, s.temerkhanov@...il.com,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] EDAC/thunderx: Fix an error message

On Thu, May 06, 2021 at 07:49:34AM +0200, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> No error code is available, so just remove it from the error message.
> 
> Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/edac/thunderx_edac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 0eb5eb97fd74..f13674081cb6 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -1368,7 +1368,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
>  					      name, 1, "CCPI", 1,
>  					      0, NULL, 0, idx);
>  	if (!edac_dev) {
> -		dev_err(&pdev->dev, "Cannot allocate EDAC device: %d\n", ret);
> +		dev_err(&pdev->dev, "Cannot allocate EDAC device\n");
>  		return -ENOMEM;
>  	}
>  	ocx = edac_dev->pvt_info;
> @@ -1380,7 +1380,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
>  
>  	ocx->regs = pcim_iomap_table(pdev)[0];
>  	if (!ocx->regs) {
> -		dev_err(&pdev->dev, "Cannot map PCI resources: %d\n", ret);
> +		dev_err(&pdev->dev, "Cannot map PCI resources\n");
>  		ret = -ENODEV;
>  		goto err_free;
>  	}
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette