linux-kernel - Re: [PATCH v2] mmc: block: ioctl: No busywaiting of non-TRAN CMDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 16:07:02 +0000
From:   Christian Löhle <CLoehle@...erstone.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     Avri Altman <Avri.Altman@....com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v2] mmc: block: ioctl: No busywaiting of non-TRAN CMDs

On Friday, May 7, 2021 1:34 PM,Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> None of the commands you are checking for should have an R1B response
> according to the spec, I think.
> 
> That said, I don't think we should do these kinds of sanity checks in
> the kernel for the mmc ioctls, that just doesn't scale.

You are absolutely correct, my bad, I had a userspace program setting the
flags wrong.
Even for a SEND_STATUS R1B is only expected if the card was not selected
and should be set accordingly by the userspace.

Regards,
Christian
Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
Managing Directors: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782