linux-kernel - Re: [PATCH] iio: adc: ad7768-1: Fix the right interrupt interface calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 18:29:36 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Tang Bin <tangbin@...s.chinamobile.com>,
        Michael.Hennerich@...log.com, jic23@...nel.org, knaack.h@....de,
        pmeerw@...erw.net
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] iio: adc: ad7768-1: Fix the right interrupt interface
 calls

On 5/11/21 5:31 PM, Tang Bin wrote:
> In the function ad7768_probe(), the devm_request_irq() should
> call ad7768_interrupt, not &ad7768_interrupt, so fix this mistake.
>
> Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

Hi,

Thanks for the patch. Aren't those two expressions equivalent? Are you 
seeing an issue with the current code? If so can you include that in the 
commit message?

- Lars


> ---
>   drivers/iio/adc/ad7768-1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index 0e93b0766..9c9ab56d6 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -605,7 +605,7 @@ static int ad7768_probe(struct spi_device *spi)
>   	init_completion(&st->completion);
>   
>   	ret = devm_request_irq(&spi->dev, spi->irq,
> -			       &ad7768_interrupt,
> +			       ad7768_interrupt,
>   			       IRQF_TRIGGER_RISING | IRQF_ONESHOT,
>   			       indio_dev->name, indio_dev);
>   	if (ret)