linux-kernel - Re: [PATCH v1 2/2] memory: tegra: Enable compile testing for all drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54acffad-97c0-56cd-46ba-5ceba454ec09@canonical.com>
Date:   Tue, 11 May 2021 12:41:32 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v1 2/2] memory: tegra: Enable compile testing for all
 drivers

On 10/05/2021 17:37, Dmitry Osipenko wrote:
> Enable compile testing for all Tegra memory drivers.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  drivers/memory/tegra/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
> index a70967a56e52..a910f661105f 100644
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> @@ -2,7 +2,7 @@
>  config TEGRA_MC
>  	bool "NVIDIA Tegra Memory Controller support"
>  	default y
> -	depends on ARCH_TEGRA
> +	depends on (ARCH_TEGRA || COMPILE_TEST)

No need for ().

>  	select INTERCONNECT
>  	help
>  	  This driver supports the Memory Controller (MC) hardware found on
> @@ -11,7 +11,7 @@ config TEGRA_MC
>  config TEGRA20_EMC
>  	tristate "NVIDIA Tegra20 External Memory Controller driver"
>  	default y
> -	depends on TEGRA_MC && ARCH_TEGRA_2x_SOC
> +	depends on TEGRA_MC && (ARCH_TEGRA_2x_SOC || COMPILE_TEST)

There is a lot of "depends on TEGRA_MC". How about making it a "if
TEGRA_MC" block?

Best regards,
Krzysztof