linux-kernel - RE: [PATCH] ACPICA: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR11MB1599BD99469D7F2157A4C27FF0539@MWHPR11MB1599.namprd11.prod.outlook.com>
Date:   Tue, 11 May 2021 18:20:16 +0000
From:   "Kaneda, Erik" <erik.kaneda@...el.com>
To:     Wei Ming Chen <jj251510319013@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: RE: [PATCH] ACPICA: Use fallthrough pseudo-keyword



> -----Original Message-----
> From: Wei Ming Chen <jj251510319013@...il.com>
> Sent: Thursday, May 6, 2021 5:49 AM
> To: linux-kernel@...r.kernel.org
> Cc: linux-acpi@...r.kernel.org; devel@...ica.org; Wei Ming Chen
> <jj251510319013@...il.com>
> Subject: [PATCH] ACPICA: Use fallthrough pseudo-keyword
> 
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro
> fallthrough[1]
> 
> [1]
> https://www.kernel.org/doc/html/latest/process/deprecated.html?highligh
> t=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Wei Ming Chen <jj251510319013@...il.com>
> ---
>  drivers/acpi/acpica/utprint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char
> *format, va_list args)
>  		case 'X':
> 
Hi,

>  			type |= ACPI_FORMAT_UPPER;
> -			/* FALLTHROUGH */
> +			fallthrough;

Since fallthrough is specific to gcc, we use the macro ACPI_FALLTHROUGH for code in drivers/acpi/acpica. Please resubmit using this keyword and I can take the commit for upstream ACPICA.

Thanks,
Erik
> 
>  		case 'x':
> 
> --
> 2.25.1