linux-kernel - Re: [PATCH 1/2] hugetlb: clear huge pte during flush function on mips platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210511210349.GA18846@alpha.franken.de>
Date:   Tue, 11 May 2021 23:03:49 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     bibo mao <maobibo@...ngson.cn>
Cc:     Anshuman Khandual <anshuman.khandual@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 1/2] hugetlb: clear huge pte during flush function on
 mips platform

On Mon, Jun 29, 2020 at 09:15:32PM +0800, bibo mao wrote:
> From: Bibo Mao <maobibo@...ngson.cn>
> 
> If multiple threads are accessing the same huge page at the same
> time, hugetlb_cow will be called if one thread write the COW huge
> page. And function huge_ptep_clear_flush is called to notify other
> threads to clear the huge pte tlb entry. The other threads clear
> the huge pte tlb entry and reload it from page table, the reload
> huge pte entry may be old.
> 
> This patch fixes this issue on mips platform, and it clears huge
> pte entry before notifying other threads to flush current huge
> page entry, it is similar with other architectures.
> 
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> ---
>  arch/mips/include/asm/hugetlb.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]