linux-kernel - Re: [PATCH] net/sched: taprio: Drop unnecessary NULL check after container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162077599066.17752.10688844250342653861.git-patchwork-notify@kernel.org>
Date:   Tue, 11 May 2021 23:33:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/sched: taprio: Drop unnecessary NULL check after
 container_of

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 11 May 2021 13:54:49 -0700 you wrote:
> The rcu_head pointer passed to taprio_free_sched_cb is never NULL.
> That means that the result of container_of() operations on it is also
> never NULL, even though rcu_head is the first element of the structure
> embedding it. On top of that, it is misleading to perform a NULL check
> on the result of container_of() because the position of the contained
> element could change, which would make the check invalid. Remove the
> unnecessary NULL check.
> 
> [...]

Here is the summary with links:
  - net/sched: taprio: Drop unnecessary NULL check after container_of
    https://git.kernel.org/netdev/net-next/c/faa5f5da809b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html