linux-kernel - RE: [PATCH] dt-bindings: media: renesas,drif: Use graph schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSAPR01MB27373779BEED96CA812710BEC2539@OSAPR01MB2737.jpnprd01.prod.outlook.com>
Date:   Tue, 11 May 2021 08:51:26 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Rob Herring <robh@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ramesh Shanmugasundaram <rashanmu@...il.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH] dt-bindings: media: renesas,drif: Use graph schema

Hi Rob,

thank you for your patch.

> From: Rob Herring <robh@...nel.org>
> Sent: 10 May 2021 21:35
> Subject: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
> 
> Convert the renesas,drif binding schema to use the graph schema. The
> binding referred to video-interfaces.txt, but it doesn't actually use any
> properties from it as 'sync-active' is a custom property. As 'sync-active'
> is custom, it needs a type definition.
> 
> Cc: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Ramesh Shanmugasundaram <rashanmu@...il.com>
> Cc: linux-media@...r.kernel.org
> Cc: linux-renesas-soc@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

Best regards,
Fab

> ---
>  .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> index f1bdaeab4053..ce505a7c006a 100644
> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -99,32 +99,26 @@ properties:
>        Indicates that the channel acts as primary among the bonded
> channels.
> 
>    port:
> -    type: object
> +    $ref: /schemas/graph.yaml#/properties/port
> +    unevaluatedProperties: false
>      description:
> -      Child port node corresponding to the data input, in accordance with
> the
> -      video interface bindings defined in
> -      Documentation/devicetree/bindings/media/video-interfaces.txt.
> -      The port node must contain at least one endpoint.
> +      Child port node corresponding to the data input. The port node must
> +      contain at least one endpoint.
> 
>      properties:
>        endpoint:
> -        type: object
> +        $ref: /schemas/graph.yaml#/$defs/endpoint-base
> +        unevaluatedProperties: false
> 
>          properties:
> -          remote-endpoint:
> -            description:
> -              A phandle to the remote tuner endpoint subnode in remote
> node
> -              port.
> -
>            sync-active:
> +            $ref: /schemas/types.yaml#/definitions/uint32
>              enum: [0, 1]
>              description:
>                Indicates sync signal polarity, 0/1 for low/high
> respectively.
>                This property maps to SYNCAC bit in the hardware manual.
> The
>                default is 1 (active high).
> 
> -        additionalProperties: false
> -
>  required:
>    - compatible
>    - reg
> --
> 2.27.0