linux-kernel - Re: [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 12:56:49 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Jesper Nilsson <jesper.nilsson@...s.com>,
        Lars Persson <lars.persson@...s.com>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Chris Ball <chris@...ntf.net>,
        linux-arm-kernel <linux-arm-kernel@...s.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] mmc: usdhi6rol0: fix error return code in usdhi6_probe()

On Sat, 8 May 2021 at 04:04, Zhen Lei <thunder.leizhen@...wei.com> wrote:
>
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/usdhi6rol0.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
> index 615f3d008af1..b9b79b1089a0 100644
> --- a/drivers/mmc/host/usdhi6rol0.c
> +++ b/drivers/mmc/host/usdhi6rol0.c
> @@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev)
>
>         version = usdhi6_read(host, USDHI6_VERSION);
>         if ((version & 0xfff) != 0xa0d) {
> +               ret = -EPERM;
>                 dev_err(dev, "Version not recognized %x\n", version);
>                 goto e_clk_off;
>         }
> --
> 2.25.1
>
>