linux-kernel - [RFC 0/3] tcp: Improve mtu probe preconditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <cover.1620733594.git.cdleonard@gmail.com>
Date:   Tue, 11 May 2021 15:04:15 +0300
From:   Leonard Crestez <cdleonard@...il.com>
To:     Neal Cardwell <ncardwell@...gle.com>,
        Matt Mathis <mattmathis@...gle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        John Heffner <johnwheffner@...il.com>,
        Leonard Crestez <lcrestez@...venets.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [RFC 0/3] tcp: Improve mtu probe preconditions

According to RFC4821 Section 7.4 "Protocols MAY delay sending non-probes
in order to accumulate enough data" but in practice linux only sends
probes when a lot of data accumulates on the send side.

Bigget improvement is to make tcp_xmit_size_goal (normally used for TSO)
take the probe size into account. This makes probes more likely to be
sent when applications use short writes. This should introduce no delays
beyond existing autocork heuristics.

TCP RACK allows timely loss detection with fewer outstanding packets
than fast transmit, if enabled we can use this to shrink the probe size
and require much less data for probing.

Successive mtu probes will result in reducing the cwnd since it's
measured in packets and we send bigger packets. The cwnd value can get
stuck below 11 so rework the cwnd logic in tcp_mtu_probe to be based on
the number of packets that we actually need to send.

Signed-off-by: Leonard Crestez <cdleonard@...il.com>

---

Previous RFCs:
* https://lore.kernel.org/netdev/d7fbf3d3a2490d0a9e99945593ada243da58e0f8.1619000255.git.cdleonard@gmail.com/
* https://lore.kernel.org/netdev/c575e693788233edeb399d8f9b6d9217b3daed9b.1619403511.git.lcrestez@drivenets.com/

The sysctls can probably be dropped, they're there for easy
experimentation.

It is possible that I misunderstood the meaning of "return 0 to wait"
from tcp_mtu_probe.

This introduces a bunch of mtu-to-mss calculations inside
tcp_xmit_size_goal which is called on every write. It might make sense
to cache the size of a pending probe inside icsk_mtup.probe_size. Right
now it's zero unless a probe is outstanding; a separate bit could be
used intead.

Leonard Crestez (3):
  tcp: Consider mtu probing for tcp_xmit_size_goal
  tcp: Use mtu probes if RACK is enabled
  tcp: Adjust congestion window handling for mtu probe

 Documentation/networking/ip-sysctl.rst | 10 ++++
 include/net/inet_connection_sock.h     |  4 +-
 include/net/netns/ipv4.h               |  2 +
 include/net/tcp.h                      |  1 +
 net/ipv4/sysctl_net_ipv4.c             | 14 +++++
 net/ipv4/tcp.c                         | 11 +++-
 net/ipv4/tcp_ipv4.c                    |  2 +
 net/ipv4/tcp_output.c                  | 72 +++++++++++++++++++++-----
 8 files changed, 102 insertions(+), 14 deletions(-)

base-commit: 3913ba732e972d88ebc391323999e780a9295852
-- 
2.25.1