linux-kernel - Re: linux-next: build failure after merge of the cgroup tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YJnZjCXe7uPrJxFo@carbon.DHCP.thefacebook.com>
Date:   Mon, 10 May 2021 18:10:36 -0700
From:   Roman Gushchin <guro@...com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
CC:     Tejun Heo <tj@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the cgroup tree

On Tue, May 11, 2021 at 10:51:14AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the cgroup tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:

Hi Stephen!

I've noticed this error and sent v2 almost immediately after the first version,
however it looks like the first version got merged by a mistake.

Tejun, can you, please, drop the first version and replace it with v2?
There is a trivial s/task/tsk fix.

Thank you and sorry for the confusion!

Roman

> 
> In file included from include/linux/string.h:6,
> In file included from include/linux/string.h:6,
>                  from arch/powerpc/include/asm/paca.h:15,
>                  from arch/powerpc/include/asm/current.h:13,
>                  from include/linux/sched.h:12,
>                  from include/linux/cgroup.h:12,
>                  from kernel/cgroup/cgroup-internal.h:5,
>                  from kernel/cgroup/cgroup.c:31:
> kernel/cgroup/cgroup.c: In function 'cgroup_exit':
> kernel/cgroup/cgroup.c:6270:17: error: 'task' undeclared (first use in this function); did you mean 'tsk'?
>  6270 |  if (unlikely(!(task->flags & PF_KTHREAD) &&
>       |                 ^~~~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
>    78 | # define unlikely(x) __builtin_expect(!!(x), 0)
>       |                                          ^
> kernel/cgroup/cgroup.c:6270:17: note: each undeclared identifier is reported only once for each function it appears in
>  6270 |  if (unlikely(!(task->flags & PF_KTHREAD) &&
>       |                 ^~~~
> include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
>    78 | # define unlikely(x) __builtin_expect(!!(x), 0)
>       |                                          ^
> 
> Caused by commit
> 
>   c740aad01e41 ("cgroup: inline cgroup_task_freeze()")
> 
> I have used the cgroup tree from next-20210510 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell