linux-kernel - Re: [RESEND PATCH] soundwire: dmi-quirks: remove duplicate initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJp2qYH1IQxDjgNA@vkoul-mobl.Dlink>
Date:   Tue, 11 May 2021 17:50:57 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Bard Liao <yung-chuan.liao@...ux.intel.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, srinivas.kandagatla@...aro.org,
        rander.wang@...ux.intel.com, hui.wang@...onical.com,
        pierre-louis.bossart@...ux.intel.com, sanyog.r.kale@...el.com,
        bard.liao@...el.com
Subject: Re: [RESEND PATCH] soundwire: dmi-quirks: remove duplicate
 initialization

On 11-05-21, 10:50, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> 
> cppcheck warning:
> 
> drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
> for 'map'. The initialized value is overwritten before it is
> read. [redundantInitialization]
>   for (map = dmi_id->driver_data; map->adr; map++) {
>            ^
> drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
>   struct adr_remap *map = dmi_id->driver_data;
>                         ^
> drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
>   for (map = dmi_id->driver_data; map->adr; map++) {
>            ^

Applied, thanks

-- 
~Vinod