linux-kernel - RE: [PATCH] fsl-usb: add need_oc_pp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 13:19:35 +0000
From:   "Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco)" 
        <gsanthan@...co.com>
To:     Alan Stern <stern@...land.harvard.edu>,
        "Daniel Walker (danielwa)" <danielwa@...co.com>
CC:     "HEMANT RAMDASI (hramdasi)" <hramdasi@...co.com>,
        Christian Engelmayer <christian.engelmayer@...quentis.com>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also

Hi Alan

Thanks for the review !

Yes we have to change the comment as well.

We will update the comments and resend.

Regards,
Gopal

-----Original Message-----
From: Alan Stern <stern@...land.harvard.edu> 
Sent: Friday, May 7, 2021 11:07 PM
To: Daniel Walker (danielwa) <danielwa@...co.com>
Cc: HEMANT RAMDASI (hramdasi) <hramdasi@...co.com>; Christian Engelmayer <christian.engelmayer@...quentis.com>; Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco) <gsanthan@...co.com>; xe-linux-external(mailer list) <xe-linux-external@...co.com>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also

On Fri, May 07, 2021 at 10:23:00AM -0700, Daniel Walker wrote:
> From: Gopalakrishnan Santhanam <gsanthan@...co.com>
> 
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling on 
> overcurrent.") activated the quirks handling (flag need_oc_pp_cycle) 
> for Freescale 83xx based boards.
> Activate same for 85xx based boards as well.
> 
> Cc: xe-linux-external@...co.com
> Signed-off-by: Gopalakrishnan Santhanam <gsanthan@...co.com>
> Signed-off-by: Daniel Walker <danielwa@...co.com>
> ---
>  drivers/usb/host/ehci-fsl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c 
> index 6f7bd6641694..c7d74c1a23f5 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,7 +387,7 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
>  	/* EHCI registers start at offset 0x100 */
>  	ehci->caps = hcd->regs + 0x100;
>  
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
>  	/*
>  	 * Deal with MPC834X that need port power to be cycled after the 
> power
-------------------------^

Shouldn't this comment be changed as well?

Alan Stern

>  	 * fault condition is removed. Otherwise the state machine does not
> --
> 2.25.1
>