linux-kernel - Re: [PATCH 3/6] x86/idt: remove address argument to idt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13944C28-B73C-4B2F-95C9-9395A6C21722@zytor.com>
Date:   Tue, 11 May 2021 07:43:07 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Andy Lutomirski <luto@...nel.org>
CC:     Steve Wahl <steve.wahl@....com>, Mike Travis <mike.travis@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Russ Anderson <russ.anderson@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] x86/idt: remove address argument to idt_invalidate()

Yup, me bad.

On May 11, 2021 7:14:47 AM PDT, Thomas Gleixner <tglx@...utronix.de> wrote:
>On Mon, May 10 2021 at 17:55, H. Peter Anvin wrote:
>> diff --git a/arch/x86/kernel/machine_kexec_32.c
>b/arch/x86/kernel/machine_kexec_32.c
>> index 64b00b0d7fe8..6ba90f47d8c3 100644
>> --- a/arch/x86/kernel/machine_kexec_32.c
>> +++ b/arch/x86/kernel/machine_kexec_32.c
>> @@ -232,8 +232,8 @@ void machine_kexec(struct kimage *image)
>>  	 * The gdt & idt are now invalid.
>>  	 * If you want to load them you must set up your own idt & gdt.
>>  	 */
>> -	idt_invalidate(phys_to_virt(0));
>> -	set_gdt(phys_to_virt(0), 0);
>> +	idt_invalidate();
>> +	set_gdt(0, 0);
>
>  (NULL, 0)
>
>first argument it a pointer...
>  

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.