linux-kernel - Re: [PATCH v2 1/1] spi: Assume GPIO CS active high in ACPI case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 22:37:02 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liguang Zhang <zhangliguang@...ux.alibaba.com>,
        Jay Fang <f.fangjian@...wei.com>,
        Xin Hao <xhao@...ux.alibaba.com>
Subject: Re: [PATCH v2 1/1] spi: Assume GPIO CS active high in ACPI case

On Tue, May 11, 2021 at 10:08 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Currently GPIO CS handling, when descriptors are in use, doesn't
> take into consideration that in ACPI case the default polarity
> is Active High and can't be altered. Instead we have to use the
> per-chip definition provided by SPISerialBus() resource.

I don't have access to the hardware to test this right now, but the
patch is small enough to determine that the OF case will stay the
same.
LGTM.