linux-kernel - Re: [PATCH -next] cpufreq: cppc: Remove unnecessary INIT_LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210512053642.74so7tkzsjbthybf@vireshk-i7>
Date:   Wed, 12 May 2021 11:06:42 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        rjw@...ysocki.net
Subject: Re: [PATCH -next] cpufreq: cppc: Remove unnecessary INIT_LIST_HEAD()

On 11-05-21, 19:47, Yang Yingliang wrote:
> The list_head cpu_data_list is initialized statically.
> It is unnecessary to initialize by INIT_LIST_HEAD().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 3848b4c222e1..b312fa210a39 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -723,8 +723,6 @@ static int __init cppc_cpufreq_init(void)
>  	if ((acpi_disabled) || !acpi_cpc_valid())
>  		return -ENODEV;
>  
> -	INIT_LIST_HEAD(&cpu_data_list);
> -
>  	cppc_check_hisi_workaround();
>  
>  	ret = cpufreq_register_driver(&cppc_cpufreq_driver);

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh