linux-kernel - Re: gemini: sl3516: Mainlining of NS 2502

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJw3PrZqz2q5OYbI@Red>
Date:   Wed, 12 May 2021 22:14:54 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: gemini: sl3516: Mainlining of NS 2502

Le Thu, May 06, 2021 at 01:56:28AM +0200, Linus Walleij a écrit :
> Hi Corentin,
> 
> I will check the patches you posted too, sorry for being a bit busy
> with some merge window and stuff.
> 
> On Wed, May 5, 2021 at 9:26 PM Corentin Labbe <clabbe.montjoie@...il.com> wrote:
> 
> > It seems that USB is still a bit buggy, device are detected only if plugged before boot.
> 
> Yeah :/ I don't know that driver very well, only that others use it too
> so there might be some people who can help. I haven't mainlined
> that patch because there is something that seems wrong about it
> but I'm not a USB guy.
> 
> > I hit a problem on the NS2502, sata drives does not work well:
> (...)
> > It seems a problem soon after driver probe (qc timeout and HPA error).
> > Any idea ?
> >
> > The SATA works well on my other board (SSI1328)
> > having one or two disk does not change the behavour.
> 
> Could be the SATA muxing, this thing in your device tree:
> 
> sata: sata@...00000 {
>     cortina,gemini-ata-muxmode = <0>;
>     cortina,gemini-enable-sata-bridge;
>     status = "okay";
> };
> 
> cortina,gemini-ata-muxmode should be 3 for two harddisks
> I think.
> 

I used 0, and only the second slot was working.
Using 3 fixed both slots.

Thanks