linux-kernel - Re: [PATCH v5 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb32c4e786ac73681b80b8af556543f08f076687.camel@gmail.com>
Date:   Wed, 12 May 2021 22:21:38 +0200
From:   Bean Huo <huobean@...il.com>
To:     Can Guo <cang@...eaurora.org>, asutoshd@...eaurora.org,
        nguyenb@...eaurora.org, hongwus@...eaurora.org,
        linux-scsi@...r.kernel.org, kernel-team@...roid.com
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bean Huo <beanhuo@...ron.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        Satya Tangirala <satyat@...gle.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] scsi: ufs: Introduce hba performance monitor
 sysfs nodes

On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote:
> +
> 
> +static DEVICE_ATTR_RW(monitor_enable);
> 
> +static DEVICE_ATTR_RW(monitor_chunk_size);
> 
> +static DEVICE_ATTR_RO(read_total_sectors);
> 
> +static DEVICE_ATTR_RO(read_total_busy);
> 
> +static DEVICE_ATTR_RO(read_nr_requests);
> 
> +static DEVICE_ATTR_RO(read_req_latency_avg);
> 
> +static DEVICE_ATTR_RO(read_req_latency_max);
> 
> +static DEVICE_ATTR_RO(read_req_latency_min);
> 
> +static DEVICE_ATTR_RO(read_req_latency_sum);
> 
> +static DEVICE_ATTR_RO(write_total_sectors);
> 
> +static DEVICE_ATTR_RO(write_total_busy);
> 
> +static DEVICE_ATTR_RO(write_nr_requests);
> 
> +static DEVICE_ATTR_RO(write_req_latency_avg);
> 
> +static DEVICE_ATTR_RO(write_req_latency_max);
> 
> +static DEVICE_ATTR_RO(write_req_latency_min);
> 
> +static DEVICE_ATTR_RO(write_req_latency_sum);

Can,

I like this series of patches, which can help me monitor UFS
performance online. I have a suggestion,  how do you think that we add
this to ufs-debugfs. Then we don't need to poll each parameter one by
one, just one interface.

Bean