linux-kernel - Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJstroyoV5KfEh/m@kernel.org>
Date:   Wed, 12 May 2021 04:21:50 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        linux-integrity <linux-integrity@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()

On Wed, May 12, 2021 at 09:12:26AM +0800, Leizhen (ThunderTown) wrote:
> 
> 
> On 2021/5/10 4:41, Jarkko Sakkinen wrote:
> > On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
> >> Fix to return a negative error code from the error handling
> >> case instead of 0, as done elsewhere in this function.
> >>
> >> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
> >> Reported-by: Hulk Robot <hulkci@...wei.com>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> > 
> > In the commit message:
> > 
> > 1. Instead of writing "a negative error code", write -EFAULT.
> OK, I will change it.
> 
> > 2. Some explanation of the choice.
> Do you mean why I choice error code -EFAULT? There's a similar one above this branch.
> 
>         if (nr_commands > 0xFFFFF) {
>                 rc = -EFAULT;
>                 goto out;
>         }

I mean that the commit message must rationalize whatever the commit does,
and choices made.

/Jarkko