linux-kernel - Re: [PATCH v5 1/3] kunit: make test->lock irq safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ae6e0a1-8a4c-02b0-e26d-2d6a5f107506@suse.cz>
Date:   Wed, 12 May 2021 12:28:34 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     glittao@...il.com, brendanhiggins@...gle.com, cl@...ux.com,
        penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        kunit-dev@...glegroups.com, linux-mm@...ck.org, elver@...gle.com,
        dlatypov@...gle.com
Subject: Re: [PATCH v5 1/3] kunit: make test->lock irq safe

On 5/11/21 5:07 PM, glittao@...il.com wrote:
> From: Vlastimil Babka <vbabka@...e.cz>
> 
> The upcoming SLUB kunit test will be calling kunit_find_named_resource() from
> a context with disabled interrupts. That means kunit's test->lock needs to be
> IRQ safe to avoid potential deadlocks and lockdep splats.
> 
> This patch therefore changes the test->lock usage to spin_lock_irqsave()
> and spin_unlock_irqrestore().
> 
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Oliver Glitta <glittao@...il.com>

Note v4 had

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>

and it's unchanged AFAIK.