linux-kernel - Re: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJWukRCivVE6pVhQm=ob98gDt1dn2hB_7GrisrSQ0Kc+8Q@mail.gmail.com>
Date:   Wed, 12 May 2021 13:40:21 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Sekhar Nori <nsekhar@...com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE

On Tue, May 11, 2021 at 8:06 AM Zou Wei <zou_wei@...wei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/bus/da8xx-mstpri.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index ee4c023..ff158a1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
>         { .compatible = "ti,da850-mstpri", },
>         { },
>  };
> +MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);
>
>  static struct platform_driver da8xx_mstpri_driver = {
>         .probe = da8xx_mstpri_probe,
> --
> 2.6.2
>

This module is always built-in. I don't think we require the module
device table for non-dynamic modules.

Bartosz