linux-kernel - Re: [PATCH 10/10] watchdog: keembay: Typo corrections and other blank operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 May 2021 07:05:24 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     shruthi.sanil@...el.com
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        kris.pan@...ux.intel.com, mgross@...ux.intel.com,
        srikanth.thokala@...el.com, lakshmi.bai.raja.subramanian@...el.com,
        mallikarjunappa.sangannavar@...el.com
Subject: Re: [PATCH 10/10] watchdog: keembay: Typo corrections and other
 blank operations

On Wed, May 12, 2021 at 02:17:24PM +0530, shruthi.sanil@...el.com wrote:
> From: Shruthi Sanil <shruthi.sanil@...el.com>
> 
> Corrected typos, aligned the tabs and added new lines
> wherever required for better readability
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Tested-by: Kris Pan <kris.pan@...el.com>
> Signed-off-by: Shruthi Sanil <shruthi.sanil@...el.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/keembay_wdt.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c
> index 0a8cf5b35699..6a2699021263 100644
> --- a/drivers/watchdog/keembay_wdt.c
> +++ b/drivers/watchdog/keembay_wdt.c
> @@ -26,11 +26,14 @@
>  #define WDT_TH_INT_MASK		BIT(8)
>  #define WDT_TO_INT_MASK		BIT(9)
>  #define WDT_INT_CLEAR_SMC	0x8200ff18
> +
>  #define WDT_UNLOCK		0xf1d0dead
>  #define WDT_DISABLE		0x0
>  #define WDT_ENABLE		0x1
> +
>  #define WDT_LOAD_MAX		U32_MAX
>  #define WDT_LOAD_MIN		1
> +
>  #define WDT_TIMEOUT		5
>  #define WDT_PRETIMEOUT		4
>  
> @@ -144,7 +147,7 @@ static irqreturn_t keembay_wdt_to_isr(int irq, void *dev_id)
>  	struct arm_smccc_res res;
>  
>  	arm_smccc_smc(WDT_INT_CLEAR_SMC, WDT_TO_INT_MASK, 0, 0, 0, 0, 0, 0, &res);
> -	dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt timeout.\n");
> +	dev_crit(wdt->wdd.parent, "Intel Keem Bay non-secure wdt timeout.\n");
>  	emergency_restart();
>  
>  	return IRQ_HANDLED;
> @@ -158,7 +161,7 @@ static irqreturn_t keembay_wdt_th_isr(int irq, void *dev_id)
>  	keembay_wdt_set_pretimeout(&wdt->wdd, 0x0);
>  
>  	arm_smccc_smc(WDT_INT_CLEAR_SMC, WDT_TH_INT_MASK, 0, 0, 0, 0, 0, 0, &res);
> -	dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt pre-timeout.\n");
> +	dev_crit(wdt->wdd.parent, "Intel Keem Bay non-secure wdt pre-timeout.\n");
>  	watchdog_notify_pretimeout(&wdt->wdd);
>  
>  	return IRQ_HANDLED;
> @@ -278,8 +281,8 @@ static const struct of_device_id keembay_wdt_match[] = {
>  MODULE_DEVICE_TABLE(of, keembay_wdt_match);
>  
>  static struct platform_driver keembay_wdt_driver = {
> -	.probe		= keembay_wdt_probe,
> -	.driver		= {
> +	.probe	= keembay_wdt_probe,
> +	.driver	= {
>  		.name		= "keembay_wdt",
>  		.of_match_table	= keembay_wdt_match,
>  		.pm		= &keembay_wdt_pm_ops,
> -- 
> 2.17.1
>