linux-kernel - Re: [PATCH] net: caif: Drop unnecessary NULL check after container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 May 2021 23:00:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: caif: Drop unnecessary NULL check after container_of

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 13 May 2021 09:58:40 -0700 you wrote:
> The first parameter passed to chnl_recv_cb() can never be NULL since all
> callers dereferenced it. Consequently, container_of() on it is also never
> NULL, even though the reference into the structure points to the first
> element of the structure. The NULL check is therefore unnecessary.
> On top of that, it is misleading to perform a NULL check on the result of
> container_of() because the position of the contained element could change,
> which would make the test invalid. Remove the unnecessary NULL check.
> 
> [...]

Here is the summary with links:
  - net: caif: Drop unnecessary NULL check after container_of
    https://git.kernel.org/netdev/net-next/c/0f3ee280331e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html