linux-kernel - Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 May 2021 07:42:04 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Chun-Kuang Hu <chunkuang.hu@...nel.org>
Cc:     Wang Li <wangli74@...wei.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

Hi, Wang:

Chun-Kuang Hu <chunkuang.hu@...nel.org> 於 2021年4月12日 週一 下午11:32寫道：
>
> Hi, Wang:
>
> Wang Li <wangli74@...wei.com> 於 2021年4月10日 週六 上午11:31寫道：
> >
> > pm_runtime_get_sync will increment pm usage counter even it failed.
> > Forgetting to putting operation will result in reference leak here.
> > Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> > counter balanced.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>
>
> >
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Wang Li <wangli74@...wei.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> > index 54ab3a324752..f1954242d8f6 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> > @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
> >                 drm_connector_list_iter_end(&conn_iter);
> >         }
> >
> > -       ret = pm_runtime_get_sync(crtc->dev->dev);
> > +       ret = pm_runtime_resume_and_get(crtc->dev->dev);
> >         if (ret < 0) {
> >                 DRM_ERROR("Failed to enable power domain: %d\n", ret);
> >                 return ret;
> > --
> > 2.17.1
> >