linux-kernel - Re: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210513075917.GX3425@dragon>
Date:   Thu, 13 May 2021 15:59:17 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Mian Yousaf Kaukab <ykaukab@...e.de>
Cc:     leoyang.li@....com, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node

On Wed, Apr 28, 2021 at 02:58:07PM +0200, Mian Yousaf Kaukab wrote:
> On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
> then its probe fails with the following warning:
> 
> [   10.471363] couldn't get idr
> [   10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
> ...
> [   10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
> [   10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
> 
> Reason for the failure is that bus-num property is set for dspi node.
> However, bus-num property is not set for the qspi node. If probe for
> spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
> Call to spi_register_controller() from spi-fsl-dspi driver then fails.
> Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
> optional") bus-num property is optional. Remove bus-num property from
> dspi node to fix the issue.
> 
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@...e.de>

Applied, thanks.