linux-kernel - Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <241d64eb-44e4-a838-a07a-8127c189a1c1@nvidia.com>
Date:   Thu, 13 May 2021 14:28:33 +0530
From:   Vidya Sagar <vidyas@...dia.com>
To:     Zou Wei <zou_wei@...wei.com>, <thierry.reding@...il.com>,
        <lorenzo.pieralisi@....com>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <jonathanh@...dia.com>
CC:     <linux-tegra@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE

Thanks for the patch.

Reviewed-by: Vidya Sagar <vidyas@...dia.com>

On 5/12/2021 9:37 AM, Zou Wei wrote:
> External email: Use caution opening links or attachments
> 
> 
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>   drivers/pci/controller/pci-tegra.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 8069bd9..c979229 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2539,6 +2539,7 @@ static const struct of_device_id tegra_pcie_of_match[] = {
>          { .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie },
>          { },
>   };
> +MODULE_DEVICE_TABLE(of, tegra_pcie_of_match);
> 
>   static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
>   {
> --
> 2.6.2
>