linux-kernel - Re: [PATCH -next] drm: simpledrm: print resource info using '%pr'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bc970ed-007f-6374-b7f8-71707606a6b9@suse.de>
Date:   Thu, 13 May 2021 15:03:40 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm: simpledrm: print resource info using '%pr'

Hi

Am 13.05.21 um 01:34 schrieb Randy Dunlap:
> struct resource start and end fields are not always long long,
> so using %llx to print them can cause build warnings (below).
> Fix these by using the special "%pr" for printing struct resource info.
> 
> ../drivers/gpu/drm/tiny/simpledrm.c: In function ‘simpledrm_device_init_mm’:
> ../include/drm/drm_print.h:412:32: warning: format ‘%llx’ 
expects argument of type ‘long long unsigned int’, but argument 3 has type ‘resource_size_t {aka unsigned int}’ [-Wformat=]
> ../drivers/gpu/drm/tiny/simpledrm.c:533:54: note: format string is defined here
>     drm_err(dev, "could not acquire memory range [0x%llx:0x%llx]: error 
%d\n",
>                                                     ~~~^
>                                                     %x
> ../include/drm/drm_print.h:412:32: warning: format ‘%llx’ 
expects argument of type ‘long long unsigned int’, but argument 4 has type ‘resource_size_t {aka unsigned int}’ [-Wformat=]
> ../drivers/gpu/drm/tiny/simpledrm.c:533:61: note: format string is defined here
>     drm_err(dev, "could not acquire memory range [0x%llx:0x%llx]: error 
%d\n",
>                                                            ~~~^
>                                                            %x
> 
> Fixes: 4aae79f77e3a ("drm/simpledrm: Acquire memory aperture for framebuffer")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: dri-devel@...ts.freedesktop.org

Queued up for drm-misc-next. Thanks a lot.

Best regards
Thomas

> ---
>   drivers/gpu/drm/tiny/simpledrm.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20210512.orig/drivers/gpu/drm/tiny/simpledrm.c
> +++ linux-next-20210512/drivers/gpu/drm/tiny/simpledrm.c
> @@ -530,8 +530,8 @@ static int simpledrm_device_init_mm(stru
>   
>   	ret = devm_aperture_acquire_from_firmware(dev, mem->start, resource_size(mem));
>   	if (ret) {
> -		drm_err(dev, "could not acquire memory range [0x%llx:0x%llx]: error %d\n",
> -			mem->start, mem->end, ret);
> +		drm_err(dev, "could not acquire memory range %pr: error %d\n",
> +			mem, ret);
>   		return ret;
>   	}
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)