linux-kernel - Re: [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router state and export for batman-adv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81f96696-67df-798e-ebc6-ba11f5dea3da@nvidia.com>
Date:   Thu, 13 May 2021 16:36:15 +0300
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Linus Lüssing <linus.luessing@...3.blue>
Cc:     netdev@...r.kernel.org, Roopa Prabhu <roopa@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 00/11] net: bridge: split IPv4/v6 mc router
 state and export for batman-adv

On 13/05/2021 16:34, Linus Lüssing wrote:
> On Thu, May 13, 2021 at 03:02:13PM +0300, Nikolay Aleksandrov wrote:
>> Nice work overall, thank you. I hope it was tested well. :)
>> It'd be great if later you could add some selftests.
>>
>> Cheers,
>>  Nik
> 
> Hi Nikolay,
> 
> I think I found a way now to better deal with the protocol
> specific hlist_for_each_entry(), by using hlist_for_each()
> and a helper function, to reduce the duplicate code
> with br_{ip4,ip6}_multicast_get_rport_slot() as you suggested
> (and also removing duplicate code with 
> br_{ip4,ip6}_multicast_mark_router()) and reworked patches 7
> and 9 a bit for that...
> 
> Sorry for the inconvience and my bad timing with your reviews. But
> thanks a lot for all your valuable feedback!
> 
> Also netdevbpf patchwork had a few more remarks, they should
> hopefully be fixed now, too.
> 
> Regards, Linus
> 

Awesome, I'll try to review the new set tonight or tomorrow at the latest.

Thanks,
 Nik