linux-kernel - Re: [PATCH v3 2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 May 2021 10:40:18 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     chris.chiu@...onical.com
Cc:     gregkh@...uxfoundation.org, m.v.b@...box.com, hadess@...ess.net,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] Revert "USB: Add reset-resume quirk for WD19's
 Realtek Hub"

On Thu, May 13, 2021 at 12:14:46PM +0800, chris.chiu@...onical.com wrote:
> From: Chris Chiu <chris.chiu@...onical.com>
> 
> This reverts commit ca91fd8c7643d93bfc18a6fec1a0d3972a46a18a. The

Use the proper format for referring to commits: just the first 12 hex 
digits of the commit ID, followed by the commit's name in parentheses 
and quotation marks.  See other patch submissions in the mailing list 
archives for examples.

> problematic hub should be taken care for each setting PORT_SUSPEND
> feature timeout instead of reset-resume all the time.

The last sentence is not grammatical.  It should say something more 
like:

	The previous patch in this series now handles problematic hubs
	by checking the port status when a PORT_SUSPEND timeout occurs,
	so we don't need to use reset-resume all the time.

Alan Stern

> 
> Signed-off-by: Chris Chiu <chris.chiu@...onical.com>
> ---
>  drivers/usb/core/quirks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 21e7522655ac..6114cf83bb44 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -406,7 +406,6 @@ static const struct usb_device_id usb_quirk_list[] = {
>  
>  	/* Realtek hub in Dell WD19 (Type-C) */
>  	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
> -	{ USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },
>  
>  	/* Generic RTL8153 based ethernet adapters */
>  	{ USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },
> -- 
> 2.20.1
>