linux-kernel - Re: [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about unknown chemistry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210513151103.hihvxg7kvych4nwr@earth.universe>
Date:   Thu, 13 May 2021 17:11:03 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljević <mnidza@...look.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about
 unknown chemistry

Hi,

On Tue, May 11, 2021 at 01:08:26AM +0300, Dmitry Osipenko wrote:
> Older variants of controller don't support reporting type of the battery.
> Make warning message about unknown chemistry to be printed only once in
> order to stop flooding kernel log with the message on each request of the
> property. This patch fixes the noisy messages on Asus Transformer TF101.
> 
> Tested-by: Antoni Aloy Torrens <aaloytorrens@...il.com> # TF101
> Tested-by: Nikola Milosavljević <mnidza@...look.com> # TF101
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---

I believe the problem should be fixed as side-effect of the
following patch:

https://lore.kernel.org/linux-pm/20210513020308.4011440-1-ikjn@chromium.org/

With my suggested change the message is printed once for each
battery plug, so probably only once per boot for most users.

-- Sebastian

>  drivers/power/supply/sbs-battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
> index 8d7a10730e43..b71fbf543428 100644
> --- a/drivers/power/supply/sbs-battery.c
> +++ b/drivers/power/supply/sbs-battery.c
> @@ -814,7 +814,7 @@ static int sbs_get_chemistry(struct i2c_client *client,
>  		val->intval = POWER_SUPPLY_TECHNOLOGY_UNKNOWN;
>  
>  	if (val->intval == POWER_SUPPLY_TECHNOLOGY_UNKNOWN)
> -		dev_warn(&client->dev, "Unknown chemistry: %s\n", chemistry);
> +		dev_warn_once(&client->dev, "Unknown chemistry: %s\n", chemistry);
>  
>  	return 0;
>  }
> -- 
> 2.30.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)