linux-kernel - Re: mmotm 2021-05-12-21-46 uploaded (arch/x86/mm/pgtable.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54055e72-34b8-d43d-2ad3-87e8c8fa547b@csgroup.eu>
Date:   Thu, 13 May 2021 19:09:23 +0200
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Randy Dunlap <rdunlap@...radead.org>, akpm@...ux-foundation.org,
        broonie@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: mmotm 2021-05-12-21-46 uploaded (arch/x86/mm/pgtable.c)



Le 13/05/2021 à 17:54, Randy Dunlap a écrit :
> On 5/12/21 9:47 PM, akpm@...ux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2021-05-12-21-46 has been uploaded to
>>
>>     https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
> 
> 
> on i386:
> 
> ../arch/x86/mm/pgtable.c:703:5: error: redefinition of ‘pud_set_huge’
>   int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot)
>       ^~~~~~~~~~~~
> In file included from ../include/linux/mm.h:33:0,
>                   from ../arch/x86/mm/pgtable.c:2:
> ../include/linux/pgtable.h:1387:19: note: previous definition of ‘pud_set_huge’ was here
>   static inline int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot)
>                     ^~~~~~~~~~~~
> ../arch/x86/mm/pgtable.c:758:5: error: redefinition of ‘pud_clear_huge’
>   int pud_clear_huge(pud_t *pud)
>       ^~~~~~~~~~~~~~
> In file included from ../include/linux/mm.h:33:0,
>                   from ../arch/x86/mm/pgtable.c:2:
> ../include/linux/pgtable.h:1391:19: note: previous definition of ‘pud_clear_huge’ was here
>   static inline int pud_clear_huge(pud_t *pud)
>                     ^~~~~~~~~~~~~~

Hum ...

Comes from my patch 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/5ac5976419350e8e048d463a64cae449eb3ba4b0.1620795204.git.christophe.leroy@csgroup.eu/

But, that happens only if x86 defines __PAGETABLE_PUD_FOLDED. And if PUD is folded, then I can't 
understand my it has pud_set_huge() and pud_clear_huge() functions.

Christophe