linux-kernel - Re: [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b885c7ac-2e25-6a03-4434-d0b31f92a15a@roeck-us.net>
Date:   Wed, 12 May 2021 20:15:05 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        wim@...ux-watchdog.org
Cc:     p.zabel@...gutronix.de, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: dw_wdt: Fix duplicate included linux/kernel.h

On 5/12/21 7:05 PM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
> 
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/watchdog/dw_wdt.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..b1642e2 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
>   #include <linux/delay.h>
>   #include <linux/err.h>
>   #include <linux/io.h>
> -#include <linux/kernel.h>
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
>   #include <linux/interrupt.h>
> 

When making such changes, please use the opportunity to reorder include files
in alphabetic order to help ensure that duplicate includes don't happen again.

Thanks,
Guenter