linux-kernel - Re: [PATCH 26/94] Maple Tree: Add new data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 May 2021 21:25:06 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Song Liu <songliubraving@...com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        David Rientjes <rientjes@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Rik van Riel <riel@...riel.com>,
        Michel Lespinasse <walken.cr@...il.com>
Subject: Re: [PATCH 26/94] Maple Tree: Add new data structure

* Peter Zijlstra <peterz@...radead.org> [210514 07:55]:
> On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote:
> > +static inline void mas_set_range(struct ma_state *mas, unsigned long start,
> > +		unsigned long last)
> > +{
> > +	       mas->index = start;
> > +	       mas->last = last;
> > +	       mas->node = MAS_START;
> > +}
> 
> Your indenting went wobbly :-)
> 
> Also, I personally prefer this style:
> 
> static inline void
> mas_set_range(struct ma_state *mas, unsigned long start, unsigned long last)
> {
> 	mas->index = start;
> 	mas->last = last;
> 	mas->node = MAS_START;
> }
> 
> And I'm a big proponent of at the very least keeping line-breaks aligned
> to '(', like:
> 
> static inline void mas_set_range(struct ma_state *mas, unsigned long start,
> 				 unsigned long last)
> {
> 	mas->index = start;
> 	mas->last = last;
> 	mas->node = MAS_START;
> }
> 
> Which you can get vim to do by using: set cino=(0:0
> 
> 
> 


Thanks, I will fix this.