linux-kernel - Re: [PATCH v2] seqlock,lockdep: Only check for preemption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJ4CydK5NiSkpkSO@lx-t490>
Date:   Fri, 14 May 2021 06:55:37 +0200
From:   "Ahmed S. Darwish" <a.darwish@...utronix.de>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     Peter Zijlstra <peterz@...radead.org>, bigeasy@...utronix.de,
        tglx@...utronix.de, shung-hsi.yu@...e.com,
        linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH v2] seqlock,lockdep: Only check for preemption_disabled
 in non-rt

On Thu, May 13, 2021, Davidlohr Bueso wrote:
>
> And therefore converting it to an associated spinlock would avoid the
> preemption check, which is exactly what Ahmed has already done:
>
> bc8e0adff34 (net: xfrm: Use sequence counter with associated spinlock)
> e88add19f68 (net: xfrm: Localize sequence counter per network namespace)
>
> Sorry for the noise.
>

Exactly, so it seems everything is good on your side :)

(The pending patch queue I mentioned is much larger and gets rid of the
 main packet scheduling sequence counter Qdisc::running, but I'm
 brushing it up, then sending it for an internal review round, first.
 There are already some workarounds in the RT tree for that one until
 the correct fix is merged mainline.)

Kind regards,

--
Ahmed S. Darwish
Linutronix GmbH