linux-kernel - Re: [PATCH 1/1] tools/bootconfig: Fix error return code in apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210514183238.07b96338@gandalf.local.home>
Date:   Fri, 14 May 2021 18:32:38 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] tools/bootconfig: Fix error return code in
 apply_xbc()

On Sat, 8 May 2021 11:42:16 +0800
Zhen Lei <thunder.leizhen@...wei.com> wrote:

> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
> 
> Fixes: a995e6bc0524 ("tools/bootconfig: Fix to check the write failure correctly")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Masami, care to ack this?

-- Steve

> ---
>  tools/bootconfig/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
> index 7362bef1a368..6cd6080cac04 100644
> --- a/tools/bootconfig/main.c
> +++ b/tools/bootconfig/main.c
> @@ -399,6 +399,7 @@ static int apply_xbc(const char *path, const char *xbc_path)
>  	}
>  	/* TODO: Ensure the @path is initramfs/initrd image */
>  	if (fstat(fd, &stat) < 0) {
> +		ret = -errno;
>  		pr_err("Failed to get the size of %s\n", path);
>  		goto out;
>  	}