linux-kernel - Re: arch/csky/mm/tcm.c:14:2: error: #error "You should define DTCM_RAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 May 2021 16:22:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     kernel test robot <lkp@...el.com>,
        Guo Ren <guoren@...ux.alibaba.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: arch/csky/mm/tcm.c:14:2: error: #error "You should define
 DTCM_RAM_BASE"

On 5/14/21 4:08 PM, kernel test robot wrote:
> Hi Guo,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   25a1298726e97b9d25379986f5d54d9e62ad6e93
> commit: 18c07d23da5a48525b2955aa269b8bb108c19300 csky: Fixup calltrace panic
> date:   1 year ago
> config: csky-randconfig-r036-20210515 (attached as .config)
> compiler: csky-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=18c07d23da5a48525b2955aa269b8bb108c19300
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 18c07d23da5a48525b2955aa269b8bb108c19300
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=csky 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/csky/mm/tcm.c:14:2: error: #error "You should define DTCM_RAM_BASE"
>       14 | #error "You should define DTCM_RAM_BASE"
>          |  ^~~~~
>    arch/csky/mm/tcm.c:109:7: warning: no previous prototype for 'tcm_alloc' [-Wmissing-prototypes]
>      109 | void *tcm_alloc(size_t len)
>          |       ^~~~~~~~~
>    arch/csky/mm/tcm.c:124:6: warning: no previous prototype for 'tcm_free' [-Wmissing-prototypes]
>      124 | void tcm_free(void *addr, size_t len)
>          |      ^~~~~~~~
> 
> 
> vim +14 arch/csky/mm/tcm.c
> 
> f525bb2c9e7cf1 Guo Ren 2019-11-27  11  
> f525bb2c9e7cf1 Guo Ren 2019-11-27  12  #ifdef CONFIG_HAVE_DTCM
> f525bb2c9e7cf1 Guo Ren 2019-11-27  13  #if (CONFIG_DTCM_RAM_BASE == 0xffffffff)
> f525bb2c9e7cf1 Guo Ren 2019-11-27 @14  #error "You should define DTCM_RAM_BASE"
> f525bb2c9e7cf1 Guo Ren 2019-11-27  15  #endif
> f525bb2c9e7cf1 Guo Ren 2019-11-27  16  


I.e., the person or bot that is running the kernel configurator should
set/define the Kconfig symbol CONFIG_DTCM_RAM_BASE.

Please do so in your scripts.
Thanks.

> :::::: The code at line 14 was first introduced by commit
> :::::: f525bb2c9e7cf1e3c43ab57704c9e1c836d30b34 csky: Tightly-Coupled Memory or Sram support
> 
> :::::: TO: Guo Ren <guoren@...ux.alibaba.com>
> :::::: CC: Guo Ren <guoren@...ux.alibaba.com>



-- 
~Randy