linux-kernel - Re: [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture begin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6649fad-c2ca-1808-4227-8bcb373f66bd@codeaurora.org>
Date:   Fri, 14 May 2021 12:20:46 +0530
From:   Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
        robh+dt@...nel.org, plai@...eaurora.org, bgoswami@...eaurora.org,
        perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
        rohitkr@...eaurora.org, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, swboyd@...omium.org,
        judyhsiao@...omium.org
Subject: Re: [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture
 begin

Hi Brown,

Thanks for your review comments!!!

On 5/13/2021 7:01 PM, Mark Brown wrote:
> On Thu, May 13, 2021 at 05:15:39PM +0530, Srinivasa Rao Mandadapu wrote:
>
>> +	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> +		ret = regmap_fields_write(i2sctl->spken, id,
>> +						 LPAIF_I2SCTL_SPKEN_ENABLE);
>> +	} else  {
>> +		ret = regmap_fields_write(i2sctl->micen, id,
>> +						 LPAIF_I2SCTL_MICEN_ENABLE);
>> +	}
> This commit doesn't remove the matching update in triger() so we'd have
> two redundant updates.  I guess it's unlikely to be harmful but it looks
> wrong/confusing.

Yes, It's not harmful, as clk_prepare_enable is enabling clock only once 
but maintaining count.

As Some times in Suspend/resume Sequence not hitting startup/shutdown, 
but Trigger, so for maintaining

consistency not removed in trigger.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.