linux-kernel - Re: [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJ4h16jjImjvqAKx@kroah.com>
Date:   Fri, 14 May 2021 09:08:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Qiheng Lin <linqiheng@...wei.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        zhenwei pi <pizhenwei@...edance.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mihai Carabas <mihai.carabas@...cle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Shile Zhang <shile.zhang@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE

On Fri, May 14, 2021 at 03:01:03PM +0800, Qiheng Lin wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> ---
>  drivers/misc/pvpanic/pvpanic-pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 9ecc4e8559d5..ccd7e32d3f55 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[]  = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
>  	{}
>  };
> +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
>  
>  static ssize_t capability_show(struct device *dev,
>  			       struct device_attribute *attr, char *buf)
> 

As I have said before, unless you have a user that reports a real
problem with these types of modules not automatically loading, I am not
going to take these patches, and you should probably stop generating
them.

thanks,

greg k-h