linux-kernel - Re: [PATCH -next] ALSA: gus: Replace unsafe strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hv97l92pu.wl-tiwai@suse.de>
Date:   Fri, 14 May 2021 09:47:09 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <perex@...ex.cz>, <tiwai@...e.com>, <gregkh@...uxfoundation.org>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] ALSA: gus: Replace unsafe strcpy() with strscpy()

On Fri, 14 May 2021 09:05:07 +0200,
YueHaibing wrote:
> 
> Fix smatch warning:
> sound/isa/gus/gus_main.c:396 snd_gus_check_version() error:
>  strcpy() 'card->longname' too large for 'card->shortname' (80 vs 32)
> 
> Even if this is not a real bug since the longest length of card->longname
> now is 31, replace strcpy() with strscpy() in order to avoid possible
> future mistake.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied, thanks.


Takashi