linux-kernel - Re: [PATCH] arm64: dts: mt8183: add cbas node under cros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <daeb031a-1992-704b-49bf-c935078f15f8@collabora.com>
Date:   Fri, 14 May 2021 10:55:03 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Ikjoon Jang <ikjn@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Jiri Kosina <jikos@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, linux-input@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Hsinyi Wang <hsinyi@...omium.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: mt8183: add cbas node under cros_ec

Hi Ikjoon,

Thank you for the patch.

On 13/5/21 3:45, Ikjoon Jang wrote:
> On Thu, May 13, 2021 at 12:38 AM Matthias Brugger
> <matthias.bgg@...il.com> wrote:
>>
>> Hi Ikjoon,
>>
>> On 10/05/2021 11:26, Ikjoon Jang wrote:
>>> Add a 'cbas' device node for supporting table mode switch in
> 
> tablet
> 
>>> kukui devices.
>>>
>>> Kukui platforms with detacheable base have an additional input
>>> device under cros-ec, which reports SW_TABLET_MODE regarding
>>> its base state (e.g. base flipped or detached).
>>>
>>> Signed-off-by: Ikjoon Jang <ikjn@...omium.org>
>>> ---
>>>
>>>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> index ff56bcfa3370..40030ed48854 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
>>>                       compatible = "google,extcon-usbc-cros-ec";
>>>                       google,usb-port-id = <0>;
>>>               };
>>> +
>>> +             base_detection: cbas {


This should be just cbas, remove base_detection. It was a bit confusing follow
these series. If [v5, 2/2] is already applied in hid tree, I'd suggest send a v7
version including:

[v7, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
[v7, 2/2] arm64: dts: mt8183: add cbas node under cros_ec

Both patches can go through the Matthias tree, but the first one also needs an
Ack from Lee Jones, MFD maintainer, which I think is not cc'ied, so unlikely to
give you the needed ack.

Thanks,
  Enric


>>> +                     compatible = "google,cros-cbas";
>>
>> I'm not able to find any binding description for this. It seems linux-next has
>> driver binding to this compatible, but the description is missing.
>>
>> Can you please clarify.
> 
> Yep, that's correct.
> Let me resend this with v2 after the dt-binding patch is applied.
> 
> In this series, I requested queueing these to hid tree:
> 
> [v5, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
> https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-2-ikjn@chromium.org/
> 
> [v5, 2/2] HID: google: Add of_match table to Whiskers switch device.
> https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-3-ikjn@chromium.org/
> 
> Later I found that I missed a comment from [v5, 1/2]
> But only [v5, 2/2] part is already applied to hid tree as I asked for it.
> 
> I sent a v6 dt-binding patch is here (not yet applied)
> https://patchwork.kernel.org/project/linux-input/patch/20210512100832.3878138-1-ikjn@chromium.org/
> 
>>
>> Thanks,
>> Mathias
>>
>>> +             };
>>>       };
>>>  };
>>>
>>>