linux-kernel - Re: [PATCH 2/2] kfence: only handle kernel mode faults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANpmjNNWyu2a7zqkiPK9inSM8+shXW_ppR=BKd8GFHTTi_+z9Q@mail.gmail.com>
Date:   Fri, 14 May 2021 12:59:29 +0200
From:   Marco Elver <elver@...gle.com>
To:     Sven Schnelle <svens@...ux.ibm.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] kfence: only handle kernel mode faults

On Fri, 14 May 2021 at 12:55, Sven Schnelle <svens@...ux.ibm.com> wrote:
>
> Marco Elver <elver@...gle.com> writes:
>
> > On Fri, 14 May 2021 at 11:22, Sven Schnelle <svens@...ux.ibm.com> wrote:
> >>
> >> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> >> ---
> >>  mm/kfence/core.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> >> index bc15e3cb71d5..161df492750c 100644
> >> --- a/mm/kfence/core.c
> >> +++ b/mm/kfence/core.c
> >> @@ -813,6 +813,9 @@ bool kfence_handle_page_fault(unsigned long addr, bool is_write, struct pt_regs
> >>         enum kfence_error_type error_type;
> >>         unsigned long flags;
> >>
> >> +       if (user_mode(regs))
> >> +               return false;
> >> +
> >
> > I don't think it's required on all architectures, correct? If so, I
> > think this should be part of the arch-specific code, i.e. just do "if
> > (user_mode(regs) && kfence_handle_page_fault(...))" or similar.

Ah, this should have obviously been "if (!user_mode(regs) &&
kfence_handle_page_fault(...))", but I think you would have caught
that anyway. ;-)

> > Because otherwise we'll wonder in future why we ever needed this, and
> > e.g. determine it's useless and remove it again. ;-) Either that, or a
> > comment. But I'd prefer to just keep it in the arch-specific code if
> > required, because it seems to be the exception rather than the norm.
>
> Ok, that's fine, i add it to our code then.

Sounds good.

Thanks,
-- Marco

> Thanks
> Sven